search

jameslnewell / styled-components-breakpoint

Utility function for using breakpoints with styled-components 💅.
243 stars 17 forks source link

Peer dependency for styled-components should include v4 as well. #17

Closed callmeberzerker closed 6 years ago

daviddelusenet commented 6 years ago

+1

Is there any progress on this?

jameslnewell commented 6 years ago

Not at the moment. Please create a PR bumping the version and peerDependency and I'll merge + publish.

daviddelusenet commented 6 years ago

@jameslnewell I fixed this on a local branch but when trying to push I get the following error:

ERROR: Permission to jameslnewell/styled-components-breakpoint.git denied to daviddelusenet.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
callmeberzerker commented 6 years ago

@daviddelusenet you need to create Pull Request -> not to try to push directly to this repo.

daviddelusenet commented 6 years ago

@SpearThruster I cloned this repo locally, made a new branch called styled-components-peer-dependency-update and then followed the following instructions.

After executing git push -u origin styled-components-peer-dependency-update (so the first step) I get the error mentioned above.

Am I doing something wrong?

callmeberzerker commented 6 years ago

@daviddelusenet did you fork this repo? and then you need to clone your own repo?

daviddelusenet commented 6 years ago

This issue is fixed in https://github.com/jameslnewell/styled-components-breakpoint/pull/18

jameslnewell commented 6 years ago

Thanks!