search

jameslnewell / styled-components-breakpoint

Utility function for using breakpoints with styled-components 💅.
243 stars 17 forks source link

Use react-styled-flexboxgrid breakpoints #3

Closed Un3qual closed 7 years ago

jameslnewell commented 7 years ago

Hi @Un3qual. Thanks for the PR. What's the benefit in using these breakpoints?

BTW you can already use your own set of breakpoints as described here

Un3qual commented 7 years ago

They're the same breakpoints as react-styled-flexboxgrid and the version for non-styled-components. It would just match a popular styled-components grid library. They're also the same as Bootstrap's. It's not a huge thing, just less config for popular libs. I could close this an create a new PR with just a README change to show the config for bootstrap and react-styled-flexboxgrid On Thu, Apr 20, 2017 at 5:41 PM James Newell notifications@github.com wrote:

Hi @Un3qual https://github.com/Un3qual. Thanks for the PR. What's the benefit in using these breakpoints?

BTW you can already use your own set of breakpoints as described here https://github.com/jameslnewell/styled-components-breakpoint#using-custom-breakpoints

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jameslnewell/styled-components-breakpoint/pull/3#issuecomment-295989233, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1W00Be8kGTIYKWb4doEzKpEsESKRAtks5rx_sqgaJpZM4NDpRZ .

jameslnewell commented 7 years ago

Yeah, without any research indicating they're better I'd probably prefer to keep the current ones for now. By all means update the README with them!

P.S. Have you seen https://github.com/jameslnewell/styled-components-grid 😉