search

jameslnewell / xhr-mock

Utility for mocking XMLHttpRequest.
196 stars 48 forks source link

Improvements #17

Closed emirotin closed 7 years ago

emirotin commented 7 years ago

This overlaps with https://github.com/jameslnewell/xhr-mock/pull/16. Please feel free to reject if you find that approach better fitting your goals, or let me know if you want me to update it after merging that PR.

Basically, I've been following two goals: 1) mock requests with unpredictable query params (and decided to implement regexes which are not elegant at all, but universal) 2) have a convenient parsed query to only reply to the requests with specific GET params

jameslnewell commented 7 years ago

Thanks for taking the time and effort to submit this PR! I've got a few minor comments/requests above.

jameslnewell commented 7 years ago

Oh, and can you update the doco to reflect the possibility of using a regexp. and the changelog. thanks!

andrewjtait commented 7 years ago

I was just looking at how to add this feature, great to see it already in progress! I've tested this branch with my project and it works as I'd expect - thanks @emirotin and @boggan.

emirotin commented 7 years ago

Updated

jameslnewell commented 7 years ago

💄 Beautiful, thanks! Doesn't look like any breaking changes, version 1.8.0?

emirotin commented 7 years ago

Yeah, I think 1.8.0

On Tue, Feb 7, 2017 at 4:16 AM James Newell notifications@github.com wrote:

Merged #17 https://github.com/jameslnewell/xhr-mock/pull/17.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jameslnewell/xhr-mock/pull/17#event-951320208, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgGCG1M-8Oj_b-atc1o14NceH02i5Xqks5rZ8XegaJpZM4L1DQC .