jamesludwig / procfw

Automatically exported from code.google.com/p/procfw
0 stars 0 forks source link

Even if CAT_ISO is used, virtual_pbp misdetects ms0:/ISO as iso folder #298

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. install game_categories_lite 
[http://wololo.net/talk/viewtopic.php?f=28&t=7371]
2. put ISOs to ms0:/ISO/CAT_ISO/

What is the expected output? What do you see instead?
CAT_ISO isn't listed as folder

What version of the product are you using? On what operating system?
PSP-2000 [C] 6.60ME1.3/PRO-B9

Please provide any additional information below.
Use Vshctrl/virtual_pbp.c:is_iso() as patch.

Original issue reported on code.google.com by popsd...@gmail.com on 25 Sep 2011 at 9:31

Attachments:

GoogleCodeExporter commented 8 years ago
Actually this issue happens with xxx:/<anychars>ISO, because

char * ext = dir->d_name + strlen(dir->d_name) - 3;

//filename length check

if (ext > dir->d_name) {

    //check extension

    if (stricmp(ext, "iso") == 0 || stricmp(ext, "cso") == 0) {

        //valid iso detected (more checks can be added here lateron)

        result = 1;

    }

}

this code actually detects any filename ending with "iso".
if you need to check extension, you should check ".iso" instead.

Original comment by popsd...@gmail.com on 25 Sep 2011 at 9:38

GoogleCodeExporter commented 8 years ago
I added this patch to realyoti-promod and it works great on 6.20 psp go context 
do's not work it merges folders wrong and says some is corrupt but Multi MS and 
Folders works well still Thanks this is real handy

Original comment by randqalan@gmail.com on 26 Sep 2011 at 4:34

GoogleCodeExporter commented 8 years ago
aww... actually folder mode isn't working at all here... cannot debug...

Original comment by popsd...@gmail.com on 26 Sep 2011 at 10:57

GoogleCodeExporter commented 8 years ago
Thanks for the patch. See 1192:2ab76f4710a3. I added FIO_S_ISREG check in 
addition.

Original comment by outma...@gmail.com on 2 Oct 2011 at 5:08

GoogleCodeExporter commented 8 years ago
Thanks for the patch. See 1192:2ab76f4710a3. I added FIO_S_ISREG check in 
addition.

Original comment by outma...@gmail.com on 2 Oct 2011 at 5:09