search

jamesmartin / inline_svg

Embed SVG documents in your Rails views and style them with CSS
MIT License
716 stars 73 forks source link

Fix: correct asset path for webpacker 6 when using an asset host (2) #129

Closed tessi closed 3 years ago

tessi commented 3 years ago

This PR is based on #125 and all fame should really go to @Intrepidd for implementing the fix 🙏

This is just adding a test on top, so we can hopefully merge it :) Sincerely hope this helps.

Let me know what you think @Intrepidd and @jamesmartin if you have the time to review.

tessi commented 3 years ago

I am not perfectly sure if there is a CI running this (I saw a github actions workflow) -- locally the test passes 🤞 :)

Intrepidd commented 3 years ago

Thanks :) I think in the long run we need to have tests with webpacker 6 as I started here: https://github.com/jamesmartin/inline_svg_test_app/commit/ec8a83892bc989625725d561c6d0f34f168600e7

But in the meantime this should prove the code change is safe enough to be released asap :)

tessi commented 3 years ago

Thanks :) I think in the long run we need to have tests with webpacker 6 as I started here: jamesmartin/inline_svg_test_app@ec8a838

But in the meantime this should prove the code change is safe enough to be released asap :)

I fully agree. I tried to hit the middle ground between an attempt to make this merge'able and making it perfect.