search

jamesmartin / inline_svg

Embed SVG documents in your Rails views and style them with CSS
MIT License
716 stars 72 forks source link

Drop legacy Ruby, Rails, and Webpacker support #163

Closed tagliala closed 2 months ago

tagliala commented 2 months ago

Close #161, close #162, close #164

tagliala commented 2 months ago

I'm wondering if it's worth creating a v2 branch in this repo so we can work on the 2.0 breaking changes separately from the current, stable v1.x tree. What do you think? 🤔

It will work, but I usually see the opposite: 1-stable branch, and breaking changes on master

tagliala commented 2 months ago

@jamesmartin

Since the suggested Ruby version for 6.1 is 3.0 and this is starting with 3.1, and 6.1 is going to EOL on 01 Oct 2024, I would also drop 6.1

jamesmartin commented 2 months ago

I usually see the opposite: 1-stable branch, and breaking changes on master

Fair enough. Let's go with that approach.

jamesmartin commented 2 months ago

OK. We're going with v2 changes on master, so this can be merged now. I've created a v1-stable branch for the older version.

tagliala commented 2 months ago

I would also drop 6.1

Sorry, I forgot to drop 6.1, will do that and request another review

tagliala commented 2 months ago

Welcome, I will proceed with some other changes