RuboCop: Stage IV - Githubissues

tagliala commented 1 month ago

Requires #170

I've tried to only fix objective or almost-objective offenses, if you don't like some of the fixes let me know.

There are very few changes to production code

This PR fixes:

Layout/DotPosition
Lint/AmbiguousOperator
Lint/LiteralInInterpolation
RSpec/BeEmpty
RSpec/ContextMethod
RSpec/HookArgument
RSpec/MatchArray
RSpec/NotToNot
Style/EachWithObject
Style/ExpandPathArguments
Style/HashSyntax
Style/NestedParenthesizedCalls
Style/RedundantBegin
Style/RedundantConstantBase
Style/RedundantReturn
Style/RegexpLiteral

Some manual fixes:

Lint/RedundantSplatExpansion and subsequent unsafe manual fix of Style/HashConversion
Style/NonNilCheck and subsequent switch from select !nil to reject nil

tagliala commented 1 month ago

@jamesmartin rebased and ready for review

Most of the changes are related to non-production code

There are two changes on production code with a manual fix, they have a comment and I'm quite positive they are safe

tagliala commented 3 days ago

Hi @jamesmartin, sorry for the bump

I did the requested change, I think this can be merged, there are very few changes to production code.

Then we can proceed by enabling frozen string literals, which should also save memory and improve performance (even if there are no benchmarks at the moment, I will try to do implement something: require_relative helps a lot because it will allow to use https://rubygems.org/gems/gem_bench and compare the same gem on local machine side to side)

I would like to test inline_svg for a project I have in mind from a long time (streamline Font Awesome usage in Rails applications)

jamesmartin / inline_svg

RuboCop: Stage IV #171