search

jamesmh / coravel

Near-zero config .NET library that makes advanced application features like Task Scheduling, Caching, Queuing, Event Broadcasting, and more a breeze!
https://docs.coravel.net/Installation/
MIT License
3.91k stars 257 forks source link

Smtp Mailer Does not add Reply To address #357

Closed riex406 closed 10 months ago

riex406 commented 10 months ago

When sending email with the SMTP driver and adding a Reply-To address, no reply to email address is added to the sent email. This affects only the Coravel.Mailer

Expected behavior would be for a Reply-To: address be added to the sent email and when replied to defaults to the specified email address. When using the FileLog diver there is a Reply-To line produced, just not with the current SMTP driver.

riex406 commented 10 months ago

I forked this and added the Reply To logic to the SMTP Mailer implementation. I don't contribute much to repositories, should I make a unit test for this change before submitting a pull request?

jamesmh commented 10 months ago

That would great - take a look at the existing tests for an idea 👍 Thanks!

riex406 commented 10 months ago

Thanks for merging this, I really appreciate it. I did notice that I didn't update the version number on the Coravel.Mailer package so it also didn't update NuGet. Is that something I should have included in my pull request?

jamesmh commented 10 months ago

@riex406 I'll be updating that separately and deploying a new version shortly. Thanks! 🙂

jamesmh commented 10 months ago

This is included in Coravel.Mailer version 5.0.1