search

jamesmills / laravel-timezone

Enable user Timezones in your application.
MIT License
677 stars 91 forks source link

Method `ConvertFromLocal` should add `time` when is not present. #22

Closed amandiobm closed 3 years ago

amandiobm commented 4 years ago

Method ConvertFromLocal should add time when is not present.

When called the method using 2020-01-01 with no time the method it simply returns the date in "UTC format".

Should this method add the time when it is not preset?!

cheers.

jamesmills commented 4 years ago

Why would anyone call this if it was not using a date input value?

Makes me think maybe you could use the trait to automatically do this on a submitted request value. You would simple add the value to the model like you would with adding additional datetime options?

jamesmills commented 4 years ago

@amandiobm do you still see this is as an issue?