jamesmills / laravel-timezone

Enable user Timezones in your application.
MIT License
678 stars 91 forks source link

Multiple enhancements for new version #68

Open sergotail opened 3 years ago

sergotail commented 3 years ago
jamesmills commented 3 years ago

wow!

Sorry @sergotail I totally missed this. Thank you for taking the time to contribute all this.

I'll have to find some time to dig into it all, thanks again!

jamesmills commented 3 years ago

@sergotail I've just found time to go over this and I think most of what you have done is the basis for a version 2 of this package and I think we could probably squash all other PR's once we use your updates as the base for v2.

I guess my question is what happens when we add all this stuff to a v2 and people want to upgrade, I don't really have time to write an upgrade guide.

I also think there is a handful of other PR's that we might need to merge into this. I'm also thinking we could remove some stuff like the flash messages and config and just allow people to hook into our internal events if they want to do something....

I've also just seen a PR about not using the DB to store this but just add it to the session. Maybe an option to add a "don't persist in database flag" or something.

What do you think? Shall we create a 2.0.0 branch and then merge your changes into that and then work on the other outstanding requests?

Thanks so much for everything!

sergotail commented 3 years ago

@jamesmills Sorry for late answer, i've just found time to go back to your great package and my pull request. I think it's a great idea to start 2.0.0 branch and merge my changes into it. Also i would add some minor fixes to this branch that i found after current pull request created.