jamesmills / laravel-timezone

Enable user Timezones in your application.
MIT License
675 stars 89 forks source link

Issue with require #92

Closed jackkitley closed 1 year ago

jackkitley commented 1 year ago

Problem 1

jackkitley commented 1 year ago

Problem 1

jamesmills commented 1 year ago

OK looks like torann/geoip has some fixed requirements for the old illuminate stuff.

https://github.com/Torann/laravel-geoip/blob/master/composer.json#L20

Also looks like there is an open PR to for L10 https://github.com/Torann/laravel-geoip/pull/223

I'll wait to see if this gets merged and if not then I'll switch out to use stevebauman/location but I think this would require a major version tag (breaking change).

jackkitley commented 1 year ago

Ah sorry

I misread it as merged when I had a look but I see question asked 7 hours ago.

Thanks

On Sat, 18 Feb 2023, 17:21 James Mills, @.***> wrote:

OK looks like torann/geoip has some fixed requirements for the old illuminate stuff.

https://github.com/Torann/laravel-geoip/blob/master/composer.json#L20

Also looks like there is an open PR to for L10 Torann/laravel-geoip#223 https://github.com/Torann/laravel-geoip/pull/223

I'll wait to see if this gets merged and if not then I'll switch out to use stevebauman/location https://github.com/stevebauman/location but I think this would require a major version tag (breaking change).

— Reply to this email directly, view it on GitHub https://github.com/jamesmills/laravel-timezone/issues/92#issuecomment-1435698850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYXYBSJ2QSEIUKFEGXOXA3WYDSHDANCNFSM6AAAAAAVAMWPXE . You are receiving this because you authored the thread.Message ID: @.***>

jackkitley commented 1 year ago

@jamesmills still open i see. odd that it isnt being merged.