jamesmontemagno / ImageCirclePlugin

Circle Images for your Xamarin.Forms Applications
MIT License
240 stars 68 forks source link

Circular images with border contain a small bit of color from the image #5

Closed mikegottlieb closed 7 years ago

mikegottlieb commented 7 years ago

Bug

When using the plugin along with a border the very edge of the circle contains a small bit of color from the image. image

Here is the use of the plugin in XAML <controls:CircleImage Source="{Binding MySource}" Aspect="AspectFill" WidthRequest="45" HeightRequest="45" BorderThickness="5" BorderColor="White" FillColor="White" VerticalOptions="Center" HorizontalOptions="Start" Grid.Row="0" Grid.RowSpan="2" Grid.Column="1" />

Version Number of Plugin: 1.4.1 Device Tested On: iPhone 6 Simulator Tested On: iPhone 6s iOS 9.3

Expected Behavior

The purple image in the center should be displayed with just a white border that would blend into a white background.

Actual Behavior

There is a slight purple border. The color of the border matches the color at the outskirts of the image so a similar thing happens when I use images of different colors.

jamesmontemagno commented 7 years ago

Hey mike, can you take a screenshot of the actual app, i am a bit confused here as to the issue.

What was the original image?

mikegottlieb commented 7 years ago

The original image was just the round purple icon that you see with a transparent background. The image I shared is from a screenshot. I can't easily go back to that state because I never committed those changes.

I ended up going with a homebrewed solution. I have a control that draws a rounded box view. Then I have a control that puts the image (with a transparent background) over the rounded box view. I keep their width and height settings pinned to each other to maintain the illusion of a border width. It isn't the prettiest, but it got the job done.

brux88 commented 7 years ago

hello, I'm using this plugin on Android works perfectly on ios instead the border appears to be related to the width of the view:

`

` ![2017-01-16_1138](https://cloud.githubusercontent.com/assets/3495339/21979895/2ab95350-dbe1-11e6-8c70-5fbc7f74229b.png)