jamesmontemagno / MediaPlugin

Take & Pick Photos and Video Plugin for Xamarin and Windows
MIT License
713 stars 358 forks source link

Status bar not hidden on iPhone in landscape orientation, after taking photo or video. #242

Open philmoz opened 7 years ago

philmoz commented 7 years ago

Bug

Version Number of Plugin: 2.6.2 Device Tested On: iPhone 6, iOS 10.3 Simulator Tested On: N/A

Expected Behavior

When the iPhone is rotated to landscape mode, the status bar is hidden by default.

Actual Behavior

If 'UIViewControllerBasedStatusBarAppearance' is set to false in the app Info.plist file, then after calling TakePhotoAsync or Take VideoAsync, the status bar remains visible regardless of the device rotation.

Steps to reproduce the Behavior

Using the 'MediaSample' project in the Samples folder, set 'UIViewControllerBasedStatusBarAppearance' to false in the Info.plist (Add 'View controller-based status bar appearence' = NO in the Info.plist editor). Run the app on an iPhone - before taking a photo or video note that rotating the phone to landscape will hide the status bar. Take a photo or video - now when rotating the phone the status bar is no longer hidden.

philmoz commented 7 years ago

This change does not appear to fix the issue - the status bar remains locked on screen after taking a photo/video.

jamesmontemagno commented 7 years ago

I didn't push a new package at all... so not sure what you are testing...

Let me know what all you are testing and I can try to repo.

philmoz commented 7 years ago

I tested with the latest source from GitHub (not the NuGet package).

I took the MediaSample code from the GitHub source, removed the nuget package and added the latest plugin source directly to the project. I checked that the code contains the latest fix.

Tested on iPhone 6 with iOS 10.3.2.

Built with VS for Mac, and latest version of Xamarin Forms package (2.3.4.247).

jamesmontemagno commented 7 years ago

Cool, i'll take a further look and re-open :)

jamesmontemagno commented 7 years ago

Reverting my previous changes. Need to look into it more, but on my back burner for now. Feel free to investigate and send PR if you find a fix.