search

jamesmontemagno / PermissionsPlugin

Check and Request Permissions Plugin for Xamarin and Windows
MIT License
282 stars 85 forks source link

Initial support for tvOS #161

Closed diegostamigni closed 4 years ago

diegostamigni commented 4 years ago

Changes Proposed in this pull request:

diegostamigni commented 4 years ago

@jamesmontemagno any update on this? any change you want me to make?

jamesmontemagno commented 4 years ago

Is there no way to combine the ios implementation with the tvOS ones? they are similar if not the same...

You can do something like: https://github.com/xamarin/Essentials/blob/master/Xamarin.Essentials/Xamarin.Essentials.csproj#L82-L95

diegostamigni commented 4 years ago

Leave it with me, I have an idea 👌

Regards, Diego

On 10 Dec 2019, at 19:45, James Montemagno notifications@github.com wrote:

 Is there no way to combine the ios implementation with the tvOS ones? they are similar if not the same...

You can do something like: https://github.com/xamarin/Essentials/blob/master/Xamarin.Essentials/Xamarin.Essentials.csproj#L82-L95

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

diegostamigni commented 4 years ago

Right @jamesmontemagno I've unified iOS and tvOS under a .apple.cs shared file. You'll see in the code changes that I'm returning Permissions.Unknown when something isn't supported by tvOS but I wonder if we should rather throw. Up to you, if you like throwing let me know and I'll do that instead.

jamesmontemagno commented 4 years ago

If it is something not support it should return Granted I think. This is what I do on iOS/Android

diegostamigni commented 4 years ago

Fair enough, I’ll change to that then

Regards, Diego

On 12 Dec 2019, at 06:02, James Montemagno notifications@github.com wrote:

 If it is something not support it should return Granted I think. This is what I do on iOS/Android

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

diegostamigni commented 4 years ago

Back to you @jamesmontemagno .. all changes applied 😄

jamesmontemagno commented 4 years ago

Made some small edits, mostly just trying to get CI to kick off :)

diegostamigni commented 4 years ago

Super cool 👍

diegostamigni commented 4 years ago

Anything I can do to help getting this merged in @jamesmontemagno ?