search

jamesmontemagno / PermissionsPlugin

Check and Request Permissions Plugin for Xamarin and Windows
MIT License
282 stars 85 forks source link

Replaced dependency from Plugin.CurrentActivity to Xamarin.Essentials #166

Closed bondarenkod closed 4 years ago

bondarenkod commented 4 years ago

Hi! I noticed that Xamarin.Essentials already contain the same features as the Plugin.CurrentActivity, so I decide to remove this dependency and replace it with the Xamarin.Essentials. The other reason is Xamarin.Essentials is already a part of Xamarin.Forms subsystem and included as the basic package in the templated XF project.

jamesmontemagno commented 4 years ago

It is as if I made the PR to XE to replace this fully :) tehehe

jamesmontemagno commented 4 years ago

Although Essentials now actually replaces this plugin :) funnily enough.

jamesmontemagno commented 4 years ago

Just integrated this work! <3 thanks for the PR