jamesmontemagno / SettingsPlugin

Read and Write Settings Plugin for Xamarin and Windows
MIT License
324 stars 80 forks source link

Added implementation for Tizen.Net #72

Closed maltegoetz closed 7 years ago

lothrop commented 7 years ago

👍

lothrop commented 7 years ago

I've tested this with a Tizen.NET project. It requires Nuget 4.3 to install into a Tizen project. However, that is not yet available in VS 2017. Not sure how to test if this whole thing works and we've used the right identifier in the nuspec. nuget.exe 4.3.0-preview1 only extracts the package without modifying project.json or the csproj.

@onovotny, do you have any idea how we could test this?

clairernovotny commented 7 years ago

I'm not sure, maybe @rrelyea knows?

jamesmontemagno commented 7 years ago

Hey there! This is pretty cool and interesting. I am about to make huge breaking changes for V 3 and the APIs are gunna change, so I will see what I need to do to merge it in.

jamesmontemagno commented 7 years ago

What tooling do I need for VS 2017?

maltegoetz commented 7 years ago

VS 2017 is enough if you just want to compile it. If you want to try it, you need the VS tools for Tizen preview (https://developer.tizen.org/development/tizen-.net-preview/getting-started) they come with an emulator.

jamesmontemagno commented 7 years ago

Awesome thanks! will try it out, gunna take soem time with my new changes, will try to retarget to my other v3 branch

JongHeonChoi commented 7 years ago

src/Plugin.Settings.Tizen/Settings.cs Invalid parameter sequence. 151 line => Preference.Set(prefKey, Convert.ToString(-(Convert.ToDateTime(value)).ToUniversalTime().Ticks)); 159 line => Preference.Set(prefKey, ((Guid)value).ToString());

clairernovotny commented 7 years ago

@jamesmontemagno @maltegoetz if you convert this to csproj, you can now build the tizen30 and tizen40 TFM if you include my MSBuild.Sdk.Extras package.

Instructions are here https://github.com/onovotny/MSBuildSdkExtras#targeting-tizen

This work much more cleanly than project.json. All uses of project.json should be removed since it's buggy.

jamesmontemagno commented 7 years ago

Is it possible yet for the nuget support for Tizen?

clairernovotny commented 7 years ago

yes, tizen30 and tizen40 are valid TFM's and my MSBuild.Sdk.Extras project lets you multi-target to them in an SDK style project.

lothrop commented 7 years ago

I’ll schedule working on this. Will AppVeyor be able to build it?

clairernovotny commented 7 years ago

Should be since Tizen is basically .NET Standard 1.6 plus their libraries. Last I checked, there's no local tooling to install.

jamesmontemagno commented 7 years ago

Yeah good question about appveyor... probably not i guess....

clairernovotny commented 7 years ago

@jamesmontemagno AppVeyor should work. no special tooling is required, it's just library/nuget references.

lothrop commented 7 years ago

@onovotny I'm not sure if I should be targeting tizen30 or tizen40. The Nuget package Tizen.NET seemed to be only available as 3.0.0.

lothrop commented 7 years ago

All set to merge.

clairernovotny commented 7 years ago

Why are you using a nuspec and not msbuld /t:pack with an SDK style project?

clairernovotny commented 7 years ago

I guess converting to SDK style projects could be a separate PR -- but these can all be one project with multi-targeting: image

jamesmontemagno commented 7 years ago

@onovotny I don't want to use any of that new stuff, I haven't had time to actually learn all that. This works and I like to be explicit.

I also don't want to use multi-targeting at all and want them separate :)