jamesmontemagno / StoreReviewPlugin

Request app store reviews across Xamarin and Windows applications
MIT License
184 stars 24 forks source link

RequestReview not working on Android #22

Closed gogolon closed 3 years ago

gogolon commented 3 years ago

Bug

Version Number of Plugin: 2.0.0.5 Device Tested On: Xiaomi Mi A1 (Android 9) Simulator Tested On: None

Expected Behavior

Popup showing

Actual Behavior

Popup not showing

Steps to reproduce the Behavior

Call await Plugin.StoreReview.CrossStoreReview.Current.RequestReview(false);

Description

Hello, I uploaded my app to Play Store, downloaded it from there and the in-app review popup won't show. The problem does not occur on iOS, where the plugin works correctly. On Android nothing happens after calling the RequestReview function. I plugged the device and watched its output in Android Studio, but haven't found anything related. If it's a known issue that has been already fixed in the 3.1.0 version of the plugin, please let me know.

saamerm commented 3 years ago

Did you test it in the "Internal App Sharing" method of Android?

Also, did you try to take a look at this thread? https://github.com/jamesmontemagno/StoreReviewPlugin/issues/13

saamerm commented 3 years ago

@gogolon ^

gogolon commented 3 years ago

@saamerm I have just tried and it works on Internal App Sharing. So, if I understand well, this is a bug in play core that we can't do anything with?

saamerm commented 3 years ago

Yes it could be a bug, or it could just be that Android won't allow you to review in app from that play store account.

Could you try to download from a different android device using a different play store account?

gogolon commented 3 years ago

I'll try that.

Sgt-Hashtag commented 3 years ago

Its the same for me. I'm also getting not Implemented exception in one scenario. Cant figure out tht as well.

saamerm commented 3 years ago

@Sgt-Hashtag your issue is different. You are getting a exception/crash because it sounds like you have set your linker behavior but you haven't added & configured the proguard file correctly as stated in the instructions.

Sgt-Hashtag commented 3 years ago

I have . i saw that video of your and followed the exact steps :(

gogolon commented 3 years ago

I'm back. I've checked the publicly available version of the app with another device and a different Google account. Unfortunately, the popup did not show up. Is there anything else I can do?

queequac commented 3 years ago

Might be helpful if the StoreReviewImplementation class would allow to check the result of RequestReviewFlow only, without calling LaunchReviewFlow on success. If the result is not successfull, I'd rather prefer not to show the rate-button in my app at all. :)

saamerm commented 3 years ago

@gogolon if it shows up on Internal App Sharing then there’s nothing else you can do. As I shared in the closed issues as well, there are some known issues in the native play core package that are unresolved that are faced by Java/kotlin Devs as well.

saamerm commented 3 years ago

@Sgt-Hashtag i think you messaged me on Twitter that you were able to figure it out. What was your issue?

upsilondynamics commented 3 years ago

Also not working; it does nothing. Any idea?

image

saamerm commented 3 years ago

Hey @upsilondynamics !

Sgt-Hashtag commented 3 years ago

@gogolon Hey internal app sharing method works for me it shows proper pop up with review capability in android. I have not tested IOS but should work just fine

gogolon commented 3 years ago

@gogolon Hey internal app sharing method works for me it shows proper pop up with review capability in android. I have not tested IOS but should work just fine

Thanks for replying. I'm aware that it works on internal app sharing. It's not a good workaround though.

saamerm commented 3 years ago

@gogolon that's a limitation of Google's native play core library functionality. This is the exact functionality when creating android apps on Java/Kotlin as well

saamerm commented 3 years ago

Also I just noticed that your version number is < v3, the in app review functionality was not implemented in the nuget at that time

saamerm commented 3 years ago

@gogolon is this still an issue?

gogolon commented 3 years ago

According to you it's not related to this nugget, so I'm closing it now. Sorry for not doing it before.

petera2c commented 2 years ago

I am still having this issue. Was anyone able to fix it?

saamerm commented 2 years ago

@petermirmo