search

jamesmontemagno / StoreReviewPlugin

Request app store reviews across Xamarin and Windows applications
MIT License
184 stars 24 forks source link

Project with a minimum UWP version of 16299 throws System.NotImplementedException #35

Closed BurkusCat closed 2 years ago

BurkusCat commented 2 years ago

Please fill out either the bug or feature request section and remove whatever section you are not using.

Bug

On a project with Min uwp version 16299 and target 19041, if you upgrade to StoreReviewPlugin 3.3.0, the app will crash on UWP.

I think this change may be the issue? image https://github.com/jamesmontemagno/StoreReviewPlugin/commit/2f917ac00be6e602f9890e92ce15a841e9c4af93#diff-33df5eebecd5b6a4d99b60af7f0e6ad462d1e5d89106b33c07ee774d45c032a0

Version Number of Plugin: 3.3.0 Device Tested On: Windows 10 19044

Expected Behavior

Plugin supports older minimum versions of Windows

Actual Behavior

Plugin throws an exception on startup. image

The issue is fixed if you raise the minimum version of the app up to 19041.

Steps to reproduce the Behavior

  1. Create a project with Min uwp version 16299 and target 19041
  2. Use StoreReviewPlugin 3.3.0
jamesmontemagno commented 2 years ago

I now build with VS 2022 and only 19041 is there, however as long as your target is set to 19041 it should work just fine...

Can you double check your nugets file i obj/project.assets.json

you shoudl see something in there for Plugin.StoreReviewPlugin... can you copy and paste that in here

jamesmontemagno commented 2 years ago

Oh hmmm maybe i need to set -> <TargetPlatformMinVersion>10.0.16299.0</TargetPlatformMinVersion> let me see

jamesmontemagno commented 2 years ago

I sill push out 3.3.1-beta if you can try that.

BurkusCat commented 2 years ago

Hi James, 3.3.1-beta seems to work well for me, thank you! :)

jamesmontemagno commented 2 years ago

awesome!! yay! I will push this out ;)