search

jamesmontemagno / StoreReviewPlugin

Request app store reviews across Xamarin and Windows applications
MIT License
184 stars 24 forks source link

App freezes after review sent #36

Closed s153625 closed 2 years ago

s153625 commented 2 years ago

Please fill out either the bug or feature request section and remove whatever section you are not using.

Bug

Version Number of Plugin: 3.3.0 Device Tested On: Many iOS 14+ devices (iPhone 12 pro, iPad pro (2. generation),

Expected Behavior

App continues to run after review

Actual Behavior

App freezes

Steps to reproduce the Behavior

  1. Use StoreReviewPlugin 3.3.0
  2. Submit review with user Xamarin forms version: 5.0.0.2291 Xamarin.ios: 152.0.17

    Feature Request:

    It seems that the active window is not set correctly. The issue only occurs for iOS 14+ with the SKStoreReviewController.RequestReview that requires a windowScene.

saamerm commented 2 years ago

@s153625 could you please share a video? Because I had tested the behavior What are you testing this on?

jamesmontemagno commented 2 years ago

And also a source code example.

s153625 commented 2 years ago

Im working on an enterprise app, so I dont think that it's possible to send a good code example, but we are calling the nuget from our dependencyService after a button is clicked. We can currently only test it directly in our production app, as the error does not occur in the test version. It's only when the user actually submits the review. As seen in the video, we cant click anything after the review has been submitted (from 0:17 - 0:50 it does not respond to touches)

https://user-images.githubusercontent.com/16536664/158413276-74d1e8bf-adb0-4479-95fa-8c8d10b9de9b.mp4

saamerm commented 2 years ago

Thanks for the video @s153625 The good thing is that it happens only after they have submitted an actual review, so they won't see the popup again I will try to look into this, it is going to be difficult to try to replicate this in production

jamesmontemagno commented 2 years ago

Should we remove the code that uses the new stuff? I mean it worked before without it??....

saamerm commented 2 years ago

@jamesmontemagno we dont have access to his code, and this is the only report we have received out of >1000 downloads of the package

s153625 commented 2 years ago

@saamerm Thanks! And yeah its quite difficult to test directly in production @jamesmontemagno I don't think that it's the latest changes either as this has a problematic for a while

saamerm commented 2 years ago

@s153625 could you isolate the code used until code for RequestReview?

saamerm commented 2 years ago

@s153625 you could create a secret button to launch the review, so that if a user taps on an image 11 times, it shows the review popup. And you won't need to upload to production, just beta/internal app sharing