jamesmontemagno / StoreReviewPlugin

Request app store reviews across Xamarin and Windows applications
MIT License
184 stars 24 forks source link

Review Popup not showing on Mac Catalyst for MAUI #41

Open saamerm opened 2 years ago

saamerm commented 2 years ago

Bug

Version Number of Plugin: v5.0 Beta Device Tested On: Mac Catalyst app on MacBook Pro 2021 M1 Simulator Tested On: "My Mac"

The Plugin work for iOS apps. But the Review Popup is not showing on Mac Catalyst apps made in MAUI. Running the code doesn't do anything currently (nothing in the Application Output either)

Possible Reason

As you can see here, Apple has introduced a new function to work for Mac Catalyst : https://developer.apple.com/documentation/storekit/skstorereviewcontroller/3566727-requestreview

We are not using that, which may be the reason the popup doesn't show up https://github.com/jamesmontemagno/StoreReviewPlugin/blob/52beef6db918dc4eff5ef1ef8748e99ffc63d175/src/StoreReview.Plugin/StoreReviewImplementation.apple.cs#L98

Expected Behavior

Review popup displays

Actual Behavior

No review popup is displaying

Steps to reproduce the Behavior

saamerm commented 2 years ago

Unlike I used to before, I'm not able to build the solution when I add the plugin as a project to debug with MAUI. So I wasn't able to make the change and test

Stratosf commented 1 year ago

I would love to have this plugin on MAUI