search

jamesmontemagno / StoreReviewPlugin

Request app store reviews across Xamarin and Windows applications
MIT License
184 stars 24 forks source link

Is it possible to use this plugin *without* enabling code shrinker but with linking SDK assemblies? #42

Open mikequ-taggysoft opened 2 years ago

mikequ-taggysoft commented 2 years ago

Doc says that if Linking is set to SDK or SDK and User Assemblies, we need to create the Proguard file and set code shrinker to Proguard or r8.

But our current project specifically does not want to use code shrinker, even though it does link SDK assemblies.

We do not want to use the shrinker because it affects other parts of our app and we do not want to mess with it. We tested/compared the size with/without the shrinker and found the difference negligible for our app.

But we do want to use this plugin and keep the SDK linking setting. Is there a way to do it without enabling the shrinker?

Thanks.

saamerm commented 2 years ago

Yes you can keep the SDK linking setting without enabling the shrinker and it should still work. @mikequ-taggysoft

mikequ-taggysoft commented 2 years ago

Yes you can keep the SDK linking setting without enabling the shrinker and it should still work. @mikequ-taggysoft

@saamerm That's good to know! In that case, do we still need the proguard file at all?

saamerm commented 2 years ago

Yes I believe that is needed, but you can read more about it here. Is there a reason you dont want to include the pro guard? @mikequ-taggysoft

mikequ-taggysoft commented 2 years ago

@saamerm I don't mind including the proguard file for this particular plugin. I just don't want to enable the shrinker because I don't want the headache of maintaining exclusions for other classes/packages when the shrinker doesn't benefit our app in any significant way.

saamerm commented 1 year ago

Yes then dont shrink your code. You will have no issues, it should work. Let me know if you have any questions @mikequ-taggysoft