search

jamesmontemagno / StoreReviewPlugin

Request app store reviews across Xamarin and Windows applications
MIT License
186 stars 24 forks source link

CrossStoreReview.Current.OpenStoreReviewPage and CrossStoreReview.Current.OpenStoreListing not working on IOS 18 #55

Closed geogian98 closed 2 weeks ago

geogian98 commented 1 month ago

Hey James!

I m using Plugin.StoreReview with version 6.2.0. I just found that CrossStoreReview.Current.OpenStoreReviewPage and CrossStoreReview.Current.OpenStoreListing are not working on IOS 18, more exactly nothing is happened when I call them and there is no exception thrown.

Am I doing something wrong or there is an issue with the plugin?

Thanks a lot! I really appreciate you work!!

mikebaumannch commented 3 weeks ago

The UIApplication.SharedApplilcation.OpenUrl(url) is deprecated since iOS 10. Looks like apple removed the support by introducing iOS 18.

Because this plugin is using the deprecated overload of the OpenUrl method, iOS won't be able to open the store by url: https://github.com/jamesmontemagno/StoreReviewPlugin/blob/master/src/StoreReview.Plugin/StoreReviewImplementation.apple.cs#L39 & https://github.com/jamesmontemagno/StoreReviewPlugin/blob/master/src/StoreReview.Plugin/StoreReviewImplementation.apple.cs#L66

There is a new overload available for this api: UIApplication.SharedApplication.OpenUrl(new NSUrl(url), newUIApplicationOpenUrlOptions(), null); The new overload will work :-) Unfortunately, I am not able to create a PR for this...