Closed marcominerva closed 5 years ago
interesting.... is this not needed anymore?
What about for essentials? https://github.com/xamarin/Essentials/blob/master/Xamarin.Essentials/Xamarin.Essentials.csproj#L71
I will update this next week as I had some github issues yesterday and couldn't push code.
It depends on @onovotny's MSBuild.Sdk.Extras (used as Project Sdk): https://github.com/onovotny/MSBuildSdkExtras/blob/master/Source/MSBuild.Sdk.Extras/DefaultItems/ImplicitPackages.targets#L22
This doesn't happen with Xamarin.Essentials as it uses Microsoft.NET.Sdk as Project Sdk.
As an SDK reference, we can add additional nuget package references from there; that's not possible when used as a package reference. That's one reason for the difference.
Another is that the UWP reference should be defined as private and not included as a dependency on the generated nuget. The set of reference assemblies in there from a library perspective doesn't change; what does change are the .NET Native compiler bits. That's only relevant to apps. This helps prevent pain of package compatibility warnings too.
Ahhhhhhh i see, very interesting! Makes sense. I didn't realize it added it for me automatically.
Hi @jamesmontemagno! Any updates on this? :-)
Yup, just setting up a CI cycle on this... wonder if i can ship directly to the marketplace or not
With the latest version of the Plugin Template (5.2.0), there is a compilation warning:
So the following line:
<PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.1.5" />
Should be removed from the CSPROJ file.