jamesmontemagno / Xamarin.Forms-PullToRefreshLayout

Pull To Refresh a ScrollView or ListView in Xamarin.Forms
218 stars 49 forks source link

PullToRefresh does not work on Android #56

Closed BerserkShaa closed 5 years ago

BerserkShaa commented 5 years ago

PullToRefresh doesn't work with version Xamarin Forms 3.4 pre2

BerserkShaa commented 5 years ago

I get the following error "System.TypeLoadException: VTable setup of type Refractored.XamForms.PullToRefresh.Droid.PullToRefreshLayoutRenderer failed"

dhirensham commented 5 years ago

Same happening here. PullToRefresh from nuget, v2.2.2 Xamarin.Forms v3.4.0.1008975 VS 2017 15.9.1

The iOS side works fine. On Android, I get the above error when calling PullToRefreshLayoutRenderer.Init(); from MainActivity.OnCreate

jennablackwell commented 5 years ago

Getting the same exception as well!

mduchev commented 5 years ago

Yep, same here. Got the exception after I have tried upgrading to Forms 3.4 (latest stable)

cooliopas commented 5 years ago

Same here :(

hrq-araujo commented 5 years ago

Same error here! Looking forward to an answer

vipero07 commented 5 years ago

Downgraded to Xamarin.Forms v3.3.0.967583 and that seems to work. I guess we will have to wait on an update to Pull To Refresh to support Xamarin.Forms v3.4 (or patch it)

PlymouthRock commented 5 years ago

System.TypeLoadException: VTable setup of type Refractored.XamForms.PullToRefresh.Droid.PullToRefreshLayoutRenderer failed still generated in debug log when downgrading to Xamarin.Forms v3.3.0.967583.

However, it doesn't crash the app like it does in v3.4.

andyvasilevich commented 5 years ago

Fixed ?

quentinR0bert commented 5 years ago

I have the same issue with the XF 3.4. The FFImageLoading haved the same issue (https://github.com/luberda-molinet/FFImageLoading/issues/1154).

He fix by rebuild his plugin with the new XF Package.

So we have to wait for the same i think or download the sourc, update the XF Package and build.

andyvasilevich commented 5 years ago

@jamesmontemagno Can you update the control? Thank very much.

umairjaved932 commented 5 years ago

is this fixed? I am encountering the same error, downgrading to xamarin 3.3 didn't solve the problem for me too .

umairjaved932 commented 5 years ago

SOLVED this error by using the pulltorefresh as a local library in the project and then adding the the references directly from the library in xamarin.droid and xamarin.ios projects in Xamarin 3.4 version.

Thanks @bakhti346 for the help.

Fredhn commented 5 years ago

@umairjaved932 could you explain me how to fix it? I'm still trying to figure it out.

quentinR0bert commented 5 years ago

You have two possibility :

Dowload the source, open the solution, update the XF packages on the projects , build, remove the nuget package, put the DLL at references on yours projects in your app.

Or

Download the source, add the projects to your solution, update the XF packages on the projects , build, remove the nuget package, add reference of the project in your project.

But with this solution you use a local version of the plugin and not anymore the version of James.

@umairjaved932 can you make a Merge Request of your fix, maybe like this James will make faster the update

bakhti346 commented 5 years ago

@Fredhn Download Source, Add Pull Library to your solution and build the library with XF 3.4 and add references of the local library in your project rebuild your App. Like @quentinR0bert mentioned.

umairjaved932 commented 5 years ago

@Fredhn i used the second method which @quentinR0bert has mentioned above. You can follow the steps, hope that might help.

Yes, i had to use this as a local version to make things workout for me as soon as possible. Hope James with update the plugin sooner.

Fredhn commented 5 years ago

@quentinR0bert @bakhti346 @umairjaved932 thank you all!

007vel commented 5 years ago

@bakhti346 Worked, Thanks.

Fredhn commented 5 years ago

For those who get this problem until hot fix is not released, this is the fixed nuget package for download. Update your PullToRefreshLayout dll creating a local package source and provide its directory as source.

Refractored.XamForms.PullToRefresh.2.2.2.1.zip

quentinR0bert commented 5 years ago

Thanks for the others @Fredhn . Can you put your version (used for the Nuget Package) of the source as a PullRequest for @jamesmontemagno ?

Fredhn commented 5 years ago

Thanks for the others @Fredhn . Can you put your version (used for the Nuget Package) of the source as a PullRequest for @jamesmontemagno ?

Sure, I'll try to do this.

jamesmontemagno commented 5 years ago

Please don't publish new packages send a pull request.

I am building this now.

jamesmontemagno commented 5 years ago

Fixed