jamesmontemagno / vsts-mobile-tasks

VSTS Tasks for Mobile!
MIT License
79 stars 22 forks source link

Change package task removes elements from Android Manifest #10

Closed dhindrik closed 6 years ago

dhindrik commented 6 years ago

Original manifest has much more items than final manifest

2018-01-16T11:46:23.2663425Z Original manifest:<?xml version="1.0" encoding="utf-8"?>
2018-01-16T11:46:23.2664183Z <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="com.mysuperapp.app" android:installLocation="auto">
2018-01-16T11:46:23.2664670Z    <uses-sdk android:minSdkVersion="15" />
2018-01-16T11:46:23.2664989Z    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
2018-01-16T11:46:23.2665353Z    <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
2018-01-16T11:46:23.2665678Z   <uses-permission android:name="android.permission.INTERNET" />
2018-01-16T11:46:23.2666043Z   <uses-permission android:name="com.google.android.providers.gsf.permission.READ_GSERVICES" />
2018-01-16T11:46:23.2666394Z   <!-- Google Maps for Android v2 will cache map tiles on external storage -->
2018-01-16T11:46:23.2666748Z   <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
2018-01-16T11:46:23.2667084Z   <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
2018-01-16T11:46:23.2667448Z   <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
2018-01-16T11:46:23.2667794Z   <uses-permission android:name="android.permission.ACCESS_LOCATION_EXTRA_COMMANDS" />
2018-01-16T11:46:23.2668156Z   <uses-permission android:name="android.permission.ACCESS_MOCK_LOCATION" />
2018-01-16T11:46:23.2668665Z   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
2018-01-16T11:46:23.2668999Z   <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
2018-01-16T11:46:23.2669345Z   <uses-permission android:name="android.permission.FLASHLIGHT" />
2018-01-16T11:46:23.2669661Z   <uses-permission android:name="android.permission.CAMERA" />
2018-01-16T11:46:23.2669950Z   <application>
2018-01-16T11:46:23.2670296Z        <meta-data android:name="com.google.android.maps.v2.API_KEY" android:value="superkey" />
2018-01-16T11:46:23.2670673Z    </application>
2018-01-16T11:46:23.2670917Z </manifest>
2018-01-16T11:46:23.2671136Z true
2018-01-16T11:46:23.2671374Z Old versionCode: 1
2018-01-16T11:46:23.2672024Z New versionCode: 75
2018-01-16T11:46:23.2672334Z true
2018-01-16T11:46:23.2673061Z Old versionName: 1.0
2018-01-16T11:46:23.2673375Z New versionName: 1.0.75
2018-01-16T11:46:23.2673726Z Final manifest: <?xml version="1.0" encoding="utf-8"?>
2018-01-16T11:46:23.2674200Z <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="75" android:versionName="1.0.75" package="com.mysuperapp.app" android:installLocation="auto">
2018-01-16T11:46:23.2674675Z    <uses-sdk android:minSdkVersion="15" />
2018-01-16T11:46:23.2675050Z    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
2018-01-16T11:46:23.2675441Z    <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
2018-01-16T11:46:23.2675832Z    <uses-permission android:name="android.permission.INTERNET" />
2018-01-16T11:46:23.2678103Z    <uses-permission android:name="com.google.android.providers.gsf.permission.READ_GSERVICES" />
2018-01-16T11:46:23.2678579Z </manifest>
2018-01-16T11:46:23.2678866Z Task done!
jamesmontemagno commented 6 years ago

Can you remove this and see if it fixes it?

 <!-- Google Maps for Android v2 will cache map tiles on external storage -->
dhindrik commented 6 years ago

What should I remove?

jamesmontemagno commented 6 years ago

Sorry, see above. Forgot to put in my ` basically i think it is the comment in there.

dhindrik commented 6 years ago

You're right. I removed the comment and it works. Thank you!

jamesmontemagno commented 6 years ago

0.6.0 will automatically strip it out. Found it that it was an issue in the javascript library :(

Ty-Bot commented 5 years ago

Would there be any reason why the build puts out a lab, qa, dev and release apk as expected but only the one in the lab folder is versioned correctly?