search

jamesmoriarty / react-instagram-authless-feed

React component to provide a token-less Instagram feed.
http://www.jamesmoriarty.xyz/react-instagram-authless-feed/
49 stars 18 forks source link

Errors should be handled by error boundary #5

Closed jamesmoriarty closed 3 years ago

jamesmoriarty commented 3 years ago

Remove:

.catch(() => this.setState({ loading: false, media: [] }));

Add docs.

Usage with: https://reactjs.org/docs/error-boundaries.html

juanchoperezj commented 3 years ago

Hi @jamesmoriarty, can I work on this? I haven't work yet with error boundaries, so I think this will be a perfect start on this for me.

jamesmoriarty commented 3 years ago

Yep. It's its mainly to remove code and doument how you could use them for this compoment.

On Sat, 3 Oct. 2020, 01:46 Juan S. Pérez J., notifications@github.com wrote:

Hi @jamesmoriarty https://github.com/jamesmoriarty, can I work on this? I haven't work yet with error boundaries, so I think this will be a perfect start on this for me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jamesmoriarty/react-instagram-authless-feed/issues/5#issuecomment-702809439, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXRZ3ZJOKAGYDQAXTQINLSIXYWPANCNFSM4R7BPYPQ .