search

jamesmunns / frauth

Peer to Peer Friend Authentication
GNU General Public License v3.0
21 stars 2 forks source link

Build fails with windows gnu toolchain #9

Open Tomok opened 4 years ago

Tomok commented 4 years ago

Building on Windows via cargo install frauth fails: error: expected token:, --> ~\.cargo\registry\src\github.com-1ecc6299db9ec823\frauth-0.2.0\src\util.rs:26:9 | 26 | PATHS.user_info.display() | ^^^^^ expected,`

error: aborting due to previous error`

Tomok commented 4 years ago

this can be circumvented, by adding a "," after line 25, however at least with stable-x86_64-pc-windows-gnu it than fails with a linker error for curl (which probably is an issue with libcurl_sys and not this package):

[..]\deps\libcurl_sys-94a1f16a4b8bdb84.rlib(url.o):url.c:(.text$Curl_init_userdefined+0xa): undefined reference to `__imp___acrt_iob_func'

[..]\deps\libcurl_sys-94a1f16a4b8bdb84.rlib(cookie.o):cookie.c:(.text$Curl_cookie_init+0x27b): undefined reference to `__imp___acrt_iob_func'

[..]\deps\libcurl_sys-94a1f16a4b8bdb84.rlib(cookie.o):cookie.c:(.text$Curl_flush_cookies+0x17f): undefined reference to `__imp___acrt_iob_func'

[..]\deps\libcurl_sys-94a1f16a4b8bdb84.rlib(formdata.o):formdata.c:(.text$Curl_getformdata.part.0+0x266): undefined reference to `__imp___acrt_iob_func'

[..]\deps\libcurl_sys-94a1f16a4b8bdb84.rlib(setopt.o):setopt.c:(.text$Curl_vsetopt+0x368e): undefined reference to `__imp___acrt_iob_func'

[..]\deps\libcurl_sys-94a1f16a4b8bdb84.rlib(mprintf.o):mprintf.c:(.text$curl_mprintf+0x29): more undefined references to `__imp___acrt_iob_func' follow

jamesmunns commented 4 years ago

I don't have a windows machine handy, but I'll see if isaac or libcurl-sys offer docs regarding this, if you figure it out a PR is very welcome!

Thanks for the report!

Tomok commented 4 years ago

The pull request fixes the issue, when using the msvc toolchain. Should I create a different one for the libcurl issue when using stable-x86_64-pc-windows-gnu?