search

jamesmunns / postcard-rpc

An RPC layer for postcard based protocols
Apache License 2.0
48 stars 11 forks source link

Add support for retrying `send_resp`. #7

Open korken89 opened 4 months ago

korken89 commented 4 months ago

This adds the ability to retry an RPC and still be able to uniquely identify from which sequence number the original command came.

Feedback welcome!

jamesmunns commented 2 months ago

Hey @korken89 - I do like the idea of this, the reason I've delayed on merging it is figuring out whether we should make this a more official part of the protocol. IMO I want to mostly avoid configurables when we can (and especially config-as-generics), I'd rather dedicate a reasonable number (2-4 bits? idk) of bits of the seqno to represent retry attempts.

I'm in a flurry of work towards #10, but I do want to come back to this after that. I'm open to hear how this has worked for you in practice!