search

jamesmunns / postcard

A no_std + serde compatible message library for Rust
Apache License 2.0
788 stars 76 forks source link

This repository doesn't seem to have continuous integration #144

Closed ia0 closed 2 months ago

ia0 commented 2 months ago

This crate already has quite a few dependents but doesn't have any form of continuous integration as far as I can tell. This seems a bit risky and makes this crate looks less reliable. In particular, in #142 I realized that the tests/schema.rs could never have been run because of the wrong cfg(feature = "") gating the whole file. I understand this feature is experimental, but I would expect a repository to contain a few dead-code as possible, including tests.

Are there any plans of adding continuous integration?

jamesmunns commented 2 months ago

@ia0 I am open to adding github actions as CI, PRs definitely welcome!

ia0 commented 2 months ago

Sounds good. Let me try to write something quick. It can always be improved later.

jamesmunns commented 2 months ago

@ia0 thank you for all the support today!