jamesnetherton / homehub-cli

CLI for the BT Home Hub router
MIT License
37 stars 5 forks source link

Build failure on Fedora #13

Closed verdurin closed 7 years ago

verdurin commented 7 years ago

Hello

I've tried building and running the provided releases on Fedora 25 and see this error in each case:

make build
rm -rf build
go build -o build/homehub-cli homehub-cli.go
# command-line-arguments
./homehub-cli.go:34: cannot use readLine (type *"github.com/chzyer/readline".Instance) as type *"github.com/jamesnetherton/homehub-cli/vendor/github.com/chzyer/readline".Instance in argument to cli.NewCLI
./homehub-cli.go:90: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:106: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:112: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:139: cannot use func literal (type func(interface {}, error) error) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:148: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:156: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:181: cannot use func literal (type func(interface {}, error) error) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:189: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:197: cannot use func literal (type func([]string) (interface {}, error)) as type func(*cmd.CommandContext) in field value
./homehub-cli.go:197: too many errors
Makefile:6: recipe for target 'build' failed
make: *** [build] Error 2
verdurin commented 7 years ago

This is with the following Go RPM - golang-1.7.6-2.fc25.x86_64

jamesnetherton commented 7 years ago

I just tried to build the project from the master branch in a Fedora 25 Docker container and everything was fine.

Are you attempting to build from one of the source archives attached to the releases page?

jamesnetherton commented 7 years ago

If you want to build the latest release you can always:

git clone git@github.com:jamesnetherton/homehub-cli.git $GOPATH/src/github.com/jamesnetherton/homehub-cli
cd $GOPATH/src/github.com/jamesnetherton/homehub-cli
git checkout v0.3.0
make build
verdurin commented 7 years ago

Was using a release. Just tried again using the method you listed above and it builds, thanks.