search

jamesnetherton / homehub-metrics-exporter

Prometheus exporter for the BT Home Hub router
MIT License
6 stars 3 forks source link

Remove fixed thresholds #13

Closed malcolmholmes closed 3 years ago

malcolmholmes commented 3 years ago

Realised there were fixed values in the gauge panels. Valid for my own hub, but totally inappropriate for anyone else's. Whilst they make the dashboard a bit prettier, they unfortunately don't make sense. This PR removes the warning range (because we can't calculate it) and the fixed max (because, the panel will default to the max value returned anyway).

jamesnetherton commented 3 years ago

Please can you fix up the conflicts?

malcolmholmes commented 3 years ago

I didn't spot that you had made changes to the dashboard since mine. I've reapplied my changes to your version, which gets rid of conflicts. I changed the window to 1hr - given the min 5min window for device stats, it is more interesting, but I'm totally happy to be overruled there!

jamesnetherton commented 3 years ago

I changed the window to 1hr - given the min 5min window for device stats

The reason why I set an initial 5min window is that its better demo purposes (IMO) and getting a feel for what the dashboard offers when you're getting started, and metrics have not been scraped many times.