Preview fonts in combobox popup.

jamesni / fonts-tweak-tool

GNU Lesser General Public License v3.0

8 stars 2 forks source link

Preview fonts in combobox popup. #4

Closed ueno closed 12 years ago

ueno commented 12 years ago

This patch allows user to preview font before applying the settings. As we discussed on IRC, the behavior is similar to LibO or OOo font selection combobox,

tagoh commented 12 years ago

Two things after tried this patch:

Once clicking the combobox and pop down the list, the attribute being added in this patch still takes effect. does this mean there was no way to revert it? or a bug?
This more or less happens on OOo and LibO, and not this patch specific (regardless of how long it takes FWIW) I'm very concerned about the performance issue when opening the fonts list on the combobox. I have no idea to improve it though.

ueno commented 12 years ago

For the first thing: did you try the latest commit fe1a3bf98f8437b5bfdc1f0712aee2c098eb201 (I did git rebase...)? I can no longer reproduce the problem.

For the second, I'm thinking of another option: add a new row under each combobox and put a label showing sample text in it, instead of modifying combobox cells. This approach will reduce the number of fonts opened at the same time and won't affect performance.

ueno commented 12 years ago

Here is a screenshot of the second approach:

font-preview

tagoh commented 12 years ago

That looks good to me. though I'm not an UI designer, someone may has another idea for improvements.