search

jamesnicolas / yomichan-forvo-server

An audio server for yomichan that scrapes forvo for audio files
33 stars 16 forks source link

Incompatible with newer versions of urllib3 #16

Closed MatthiasvZ closed 1 year ago

MatthiasvZ commented 1 year ago

method_whitelist has been removed from urllib3 >=2.0, causing the add-on to crash on startup. Downgrading urllib3 temporarily fixes this issue.

'⁨Yomichan Forvo Server⁩' 読み込みの際: ⁨Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/aqt/addons.py", line 246, in loadAddons import(addon.dir_name) File "/home/matthias/.local/share/Anki2/addons21/580654285/init.py", line 190, in class ForvoHandler(http.server.SimpleHTTPRequestHandler): File "/home/matthias/.local/share/Anki2/addons21/580654285/init.py", line 191, in ForvoHandler forvo = Forvo(config=_forvo_config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/matthias/.local/share/Anki2/addons21/580654285/init.py", line 41, in init self._set_session() File "/home/matthias/.local/share/Anki2/addons21/580654285/init.py", line 48, in _set_session retry_strategy = Retry( ^^^^^^ TypeError: Retry.init() got an unexpected keyword argument 'method_whitelist' ⁩

jamesnicolas commented 1 year ago

@MatthiasvZ updated to use allowed_methods, let me know if it works for you

MatthiasvZ commented 1 year ago

Yes. It works as expected now.