search

jamesob / biketrip

The source code to a Jekyll site about our bike trip to SF.
3 stars 0 forks source link

Route Map display artifacts #1

Closed mike-zorn closed 13 years ago

mike-zorn commented 13 years ago

When the route map is displayed, there are lines across the map where there shouldn't be and text is cut off at the bottom.

jamesob commented 13 years ago

Righto. I think we may have to use iframes instead of div modifications.

mike-zorn commented 13 years ago

Good hint!

It's fixed in 4d855d870970adaad364d09707129513ad6b3bf8.

The setup is currently kinda hacky as you'd have to make two pages per post: one map page and one post page, so we should discuss exactly how we want to add posts and change the map layout accordingly.

mike-zorn commented 13 years ago

The issue is

body img, #regularMap, #usaMap {
    padding: 5px;
    line-height: 0px;
    border: 1px solid #888;
    -moz-box-shadow: 2px 2px 4px #333;
    -webkit-box-shadow: 2px 2px 4px #333;
    box-shadow: 2px 2px 4px #333;
}

from css/presentation.css gets applied to every body image, including the ones within the google map.

mike-zorn commented 13 years ago

I fixed this without an iframe in 4e9891ad8bdc7fb84a4b5cdc03f6abc6e71b4d86, but the CSS is now a bit hacky since we'll have to rewrite all the stuff that should have been applied to every body image for all the subclasses of img. However, since I can only foresee like 2 or three more subclasses of img, I think this won't be too bad.

jamesob commented 13 years ago

Good work; the img subclassing will be easy.