Enhanced desk to work nicely with the fish shell.

jamesob / desk

A lightweight workspace manager for the shell

MIT License

2.54k stars 111 forks source link

Enhanced desk to work nicely with the fish shell. #23

Closed ole108 closed 8 years ago

ole108 commented 8 years ago

I enhanced desk to work nicer with the fish shell:

The function syntax is different (the function keyword is mandatory but the parentheses are missing).
The syntax for combining commands with &&/and is different too.

I tested it on my macbook and it seems to work nicely. lint didn't get worse either. :-)

ole108 commented 8 years ago

I did some additional tests and a small cleanup. I can explain the changes I did and why I did them that way. E.g. I removed the call to find in cmd_go because:

the desk name has to be unique or the function would break in a funny way
if all the names are unique they can very well be stored in the same directory
one less call to an external executable is always nice

P.S.: Thanks a lot for the great idea of desk! :smile:

jamesob commented 8 years ago

I've absorbed this commit into https://github.com/jamesob/desk/pull/25. Thanks for the contribution, @ole108!