Closed ianberinger closed 8 years ago
Very cool, @ianberinger, and good start. Going to be taking a detailed look at this today or tomorrow.
+1
+1 Just what I need
Awesome. I'm +1 on this aside from a minor change in naming.
Thanks for reviewing. I renamed .desk to DESKFILE and fixed the merge conflict.
I'm fine with .desk or Deskfile. DESKFILE is really loud.
Sorry, my bad. Don't know how I got to the all caps version. Fixed now.
Really looking forward to this.
Feel bad blocking on small comments... I'm ready to merge this thing and iterate, though. I'll hold off on cutting a release after merge because I want to add tests and spruce up the documentation. This is close, folks! Thanks for all the work @ianberinger @rnewton!
Unfortunately this doesn't actually work for me and I've had to revert:
(venv) [Sat 13 18:41] job/code/desk master* ±
$ ls Deskfile
Deskfile
(venv) [Sat 13 18:42] job/code/desk master* ±
$ desk .
Desk # Description: the desk I use to work on desk :) (# Description: the desk I use to work on desk :).sh) not found in /Users/job/.desk/desks
I'll revisit this feature tomorrow when I have some time to code.
@jamesob, I didn't account for comments in the Deskfile. I fixed that now: https://github.com/ianberinger/desk/commit/e54c77eafc216c50390eb7c1efb3274e603798ca ; line 97 Should I open another PR
Thanks for sharing your project! This PR adds support for activating a desk based on the content of a
.desk
file in the current directory (issue #42). I updated the documentation accordingly. Feel free to close if you feel this doesn't fit the spirit of the project :)