search

jamesob / desk

A lightweight workspace manager for the shell
MIT License
2.54k stars 111 forks source link

update for proper Texan #57

Closed cfont closed 8 years ago

cfont commented 8 years ago

Texans would not say "howdy there" but instead they would say "howdy y'all"

jamesob commented 8 years ago

I owe you one of these: shiner

Fix them tests and we'll get this baby merged!

cfont commented 8 years ago

I removed the backslash within the web based github interface thinking this would be simple but after it automatically committed and ran through CI the tests failed. So, I cloned the repo and tested it myself and noticed that without the backslash on a Mac OSX 10.10.4 and bash 3.2.57 this little micro change does indeed fail. Once I re-add the backslash everything seems to work again.

To make sure this isn't a "just me" problem how would you like to proceed?

benwr commented 8 years ago

http://stackoverflow.com/questions/1250079/how-to-escape-single-quotes-within-single-quoted-strings

cfont commented 8 years ago

OK, so that still didn't work through the CI build. Not sure what to do but I'll keep working on it. I hate that it "works for me" because that makes it a little more difficult to troubleshoot, however, I can start up a docker image just like the CI build does and see what I can figure out.

jamesob commented 8 years ago

True Texan authenticity is makin' us work for it. I'm pretty sure the failure is due to tests expecting the old string.

jamesob commented 8 years ago

Boom. Thanks, @cfont.