Fixed issue with Fish shell name detection on OSX

jamesob / desk

A lightweight workspace manager for the shell

MIT License

2.54k stars 111 forks source link

Fixed issue with Fish shell name detection on OSX #65

Closed cmbankester closed 8 years ago

cmbankester commented 8 years ago

Effectively, the problem is that Fish shell on OSX can't determine shell name when parent PID is smaller than 5(ish?) characters. Took me a little while to track down the problem, but this PR fixes it for me.

Sorry that I can't demonstrate / replicate it by adding a test to the suite; the suite isn't set up to run on OSX (or outside of a docker container at all, for that matter).

bhavanki commented 8 years ago

I independently found the same problem. I think this change will fix it.

This might also resolve https://github.com/jamesob/desk/issues/64.

jamesob commented 8 years ago

Sorry for the slow response -- been traveling.

Looks great; thanks again, @cmbankester.