search

jamesofarrell / i3-swallow

used to swallow a terminal window in i3
MIT License
143 stars 10 forks source link

Doesn't swallow #7

Open GrbavaCigla opened 4 years ago

GrbavaCigla commented 4 years ago

I am on i3-gaps and it just doesn't work. I followed the steps to install it and it doesn't work.

loannaflip commented 4 years ago

@GrbavaCigla Hello there. Can I know which applications are you trying to swallow which are not working? Also can you run the program successfully without any issues excluding the not swallowing problem?

GrbavaCigla commented 4 years ago

Correction, it works on most programs, but it doesn't work on firefox. When I run it with swallow firefox it gives me i3-swallow: no process attached

arkeane commented 4 years ago

Not working with google-chrome-stable in i3-gaps too, same error i3-swallow: no process attached

TheSecureTux commented 4 years ago

If I got this right it only swallows the terminal if you launch a locking process ( Vlc or Thunar) but both browsers fork away from the terminal al soon as they launch without blocking it and letting you keep using that. I think this was the intended result and makes sense for me, I just want to get the useless terminal out of the way, not a good one.

If you want to have this behaviour with firefox you can do this:

As the default installation for FF sets in your path this launcher script below you only have to modify how you launch that slightly:


❯ cat /usr/bin/firefox
#!/bin/sh
exec /usr/lib/firefox/firefox "$@"

Try this on your terminal :

i3-swallow exec -l /usr/lib/firefox/firefox www.archlinux.org

or just i3-swallow exec chromium

It will open a FF window and swallow the terminal as you want. ~It works well for me :)~ Nvm,after several attempts looks like it's not exactly that yet, it does work for me the first time I, but if I try several times in a row the behavior appears kinda random

mcurasya commented 3 years ago

Adding another program that can't be swallowed: visual studio code. Specifically that one.

Maybe it has something to do with it opening in background.

GrbavaCigla commented 3 years ago

Well, if you look what code command does:

ELECTRON_RUN_AS_NODE=1 exec electron /usr/lib/code/out/cli.js /usr/lib/code/code.js "$@"

It is spawning in another process, so you would have to run it directly to swallow. Also since it is starting in another process and it doesn't block terminal, swallowing is kinda useless...

Edit: same reason it didn't work for firefox