search

jamesohortle / UnicodeHover

Hover over a Unicode escape in VS Code to see the glyph of the character, its description and a link to its webpage!
MIT License
12 stars 3 forks source link

Support json/jsx/tsx #13

Closed somarlyonks closed 3 years ago

somarlyonks commented 4 years ago

fixes #14

chitinlink commented 3 years ago

Please merge this! @jamesohortle

jamesohortle commented 3 years ago

@somarlyonks @technoabyss

Hello all,

Thanks for the pull request. It looks great. Before merging, my only requirement is to have test files added to the src/test folder. You can use the same Unicode codepoints used for testing in the other test files. Please add these test files to the merge request and I will merge.

Apologies for the delay in replying.

somarlyonks commented 3 years ago

@jamesohortle added

jamesohortle commented 3 years ago

@somarlyonks Hi, I'm back in lockdown again so I finally have some time to look at this. I'm trying to debug locally and it looks like the tests for HTML entities aren't successful for .tsx and .jsx files. When I hover over, for example, ě I don't see a panel. Is this expected behaviour? I'm not a react developer, so I'm not sure if the tests are failing or if this test is testing a behaviour that shouldn't exist.

jamesohortle commented 3 years ago

I'm going to go ahead and merge since it seems like there is demand for this PR. @somarlyonks if you realise that the tests are failing then please submit a new PR.