jamespacileo / django-pure-pagination

Django pagination based upon the core pagination module
BSD 3-Clause "New" or "Revised" License
701 stars 171 forks source link

Maintained fork #34

Closed jpic closed 8 years ago

jpic commented 8 years ago

Hi all, is there any maintained fork out there ?

Thanks !

lampslave commented 8 years ago

I maintain https://github.com/hovel/django-pure-pagination. I can't promise to resolve any issue, but if it will be relevant to our projects too, I'll do it.

jpic commented 8 years ago

Nice ! do you think you could do a PyPi release since dependency_links is deprecated now ?

lampslave commented 8 years ago

I don't see dependency_links in setup.py. Anyway you can install package directly from git...

jpic commented 8 years ago

On Sat, Dec 26, 2015 at 2:53 PM, lampslave notifications@github.com wrote:

I don't see dependency_links in setup.py. Anyway you can install package directly from git...

That's exactly what I do, but it seems deprecated by pip ....

I have, in my app's setup.py:

setup( # my app stuff...
    install_requires=[
        'django-pure-pagination==0.3.0',
    ],
    dependency_links=[
        'https://github.com/hovel/django-pure-pagination/archive/master.tar.gz#egg=django-pure-pagination-0.3.0',
    ]
)

Then of course use the --process-dependency-links option in pip to enable it, but it prints out a DEPRECATION warning :

$ pip install --process-dependency-links -Ue .
Obtaining file:///home/jpic/work/lqdn/political_memory
  DEPRECATION: Dependency Links processing has been deprecated and will be
removed in a future release.

Maybe there's a better, supported way ?

( sorry for reposting, i forgot github wouldn't render markup when replying by email )

lampslave commented 8 years ago

Now I understand. Maybe http://stackoverflow.com/a/16624700 will help (see comments)?

jamespacileo commented 8 years ago

Hey guys,

Apologies for my disappearance, I can merge in iampslave changes.

Would that work? Sounds like all outstanding fixes are included in his fork. On Sat, 26 Dec 2015 at 16:04, lampslave notifications@github.com wrote:

Now I understand. Maybe http://stackoverflow.com/a/16624700 will help (see comments)?

— Reply to this email directly or view it on GitHub https://github.com/jamespacileo/django-pure-pagination/issues/34#issuecomment-167330467 .

jamespacileo commented 8 years ago

I'll make it a priority to sort this out this evening after our big family dinner is over.

Merry Christmas and/or happy holidays! 😄 On Sat, 26 Dec 2015 at 16:22, James Pacileo jamespacileo@gmail.com wrote:

Hey guys,

Apologies for my disappearance, I can merge in iampslave changes.

Would that work? Sounds like all outstanding fixes are included in his fork. On Sat, 26 Dec 2015 at 16:04, lampslave notifications@github.com wrote:

Now I understand. Maybe http://stackoverflow.com/a/16624700 will help (see comments)?

— Reply to this email directly or view it on GitHub https://github.com/jamespacileo/django-pure-pagination/issues/34#issuecomment-167330467 .

lampslave commented 8 years ago

It would be great, but I'm not sure about compatibility. Probably you want to merge https://github.com/jamespacileo/django-pure-pagination/pull/32 first.

Have a nice day :)

jamespacileo commented 8 years ago

Hi @lampslave , wow the fork was pretty good.

I've merged it in! ...plus added a Dockerfile and docker-compose.yml for quickly spinning up the example.

I'll push it to PyPI as soon as I can.

jamespacileo commented 8 years ago

@lampslave @jpic latest version merged with Hovel fork pushed to PyPI

https://pypi.python.org/pypi/django-pure-pagination/0.3.0

jpic commented 8 years ago

Awesome, thanks !

lampslave commented 8 years ago

@jamespacileo I'm glad you liked it, thanks :)