jamespdaily / pf2e-sheet-skill-actions

0 stars 14 forks source link

Add support for actions undefined in game.pf2e.actions #27

Closed andriusch closed 2 years ago

andriusch commented 2 years ago

Not sure if formatting is great, but I don't think there's any other way. Basically it all comes down to 2 things:

  1. We can't access CheckPF2e.roll from module.
  2. skill.roll has very limited amount of options it supports, we can't pass custom label or traits.

So this is the best we can currently do. The only other meaningful option that I'm not using is dc, so I think we would be able to set DC of the check in the future (in case target is selected).

So in the end what it does when you roll "Steal" is post the action to the chat and then roll thievery. If this is good enough I'll add the remaining encounter mode skill actions.

BTW this also fixes #7

image

jamespdaily commented 2 years ago

How many others are there? Is there a possibility they'll add the undefined actions?

andriusch commented 2 years ago

I counted 8, though there are also exploration & downtime actions. I talked with one of the maintainers of pf2e and game.pf2e.actions is abandoned, so they will not be adding new actions nor they will accept PRs with new actions from what I understood. Instead they're working on rule elements based system where each action could define what would be rolled and etc. They're not sure what it will look like and what's the timeline on it, but as far as I understood it's a lot of work.

jamespdaily commented 2 years ago

Ah gotcha! OK well then it's probably worth it to add them then!