search

jamespdaily / pf2e-sheet-skill-actions

0 stars 14 forks source link

Add buttons to roll athletics checks with MAP #6

Closed andriusch closed 2 years ago

andriusch commented 2 years ago

Roll functions allow a list of modifiers to apply to this roll. It's a bit hacky to just pass an object to modifiers instead of initializing ModifierPF2E but I don't know if there's anything similar to @league-of-foundry-developers/foundry-vtt-types for PF2E system and the only other way I can think of is copy pasting the definition from their repo.

Screenshot

image

jamespdaily commented 2 years ago

This looks great. I was kind of on the fence about this since, as you stated, the modifiers are a bit hacky and "unsanctioned" by the PF2e system. But it's all we really have available until these skill actions get official MAP support, so I'm going to allow the merge.

jamespdaily commented 2 years ago

Also, thank you for fixing my TypeScript :P

andriusch commented 2 years ago

I really didn't do much :smiley: and my typescript is not great either, still learning :wink: