search

jamespdaily / pf2e-sheet-skill-actions

0 stars 14 forks source link

Add new setting to select icon type #60

Open thomascookandroid opened 2 years ago

thomascookandroid commented 2 years ago

The purpose of this PR is:

To add a new setting to allow user to choose between:

A) Existing behaviour of showing skill icon if available, else showing action cost icon

OR

B) New behaviour of always showing action cost icon, and removing action cost icon from the "activity-icon" span via setting the actionType to ' ' (passive)

The reason for this is that I believe it looks nicer to not have a mix of action cost icons and skill icons as is currently the case. Hence I've added an option to the settings for the users to toggle between the existing behaviour and my proposed behaviour of always just showing the action cost icon (which will then make the icon rendered in the activity-icon span pointless, so I've also added code to "hide" that when the user selects the new setting)

xdy commented 2 years ago

With the permission of @jamespdaily I'm in the process of incorporating all the functionality of pf2e-sheet-skill-actions in my module https://github.com/xdy/xdy-pf2e-workbench as he no longer has the time to maintain it. (It will be part of PF2e Workbench version 4.0.0 (which will be released once the PF2e system version 4.0.0 is released). As part of that I included this PR in PF2e Workbench version 4.0.0