OrderID type where ClientID should be used

jamespeterschinner / async_v20

Asynchronous client for FOREX broker

http://async-v20.readthedocs.io/

MIT License

12 stars 11 forks source link

OrderID type where ClientID should be used #22

Open gshklover opened 5 years ago

gshklover commented 5 years ago

Hi. Attached is a patch to replace attribute type definitions for client IDs fields 'OrderID' -> 'ClientID' (OrderID is int, while client IDs could be any string).

Additionally, a couple of attributes are added to model definitions where Oanda API documentation seems to be missing definitions comparing to actual implementation.

Thanks, Gregory.

clientid.txt

jamespeterschinner commented 3 years ago

Thanks for the issue,

I'd be more than happy to accept a pull request for this.

Well done on identifying additional attributes that are not documented. I'm sorry to see that this is still occurring years after I reached out to OANDA about it.

Regards