The main execute_feed_update function is tedious. It would be better to use a "steps" pattern, where each "step" is an object that has a perform_step method and a can_continue method. When performing each step, we check for an expected exception and error out correctly if needed, and similarly if after the step the can_continue method is false.
This is nice-to-have, and would be good to do before other code in the update manager is changed.
The main
execute_feed_update
function is tedious. It would be better to use a "steps" pattern, where each "step" is an object that has aperform_step
method and acan_continue
method. When performing each step, we check for an expected exception and error out correctly if needed, and similarly if after the step thecan_continue
method is false.This is nice-to-have, and would be good to do before other code in the update manager is changed.