Removes inoperable gitcdn failover

jamespizzurro / picket-line-notifier

A browser extension that alerts you when you navigate to a website belonging to an organization whose employees are on strike.

GNU General Public License v3.0

151 stars 9 forks source link

Removes inoperable gitcdn failover #1036

Closed katerberg closed 2 weeks ago

katerberg commented 2 weeks ago

Impacts #879

It was attempting to fail over to GitCDN, but the link was inoperable there and it is causing a firefox review flag. This resolves it by just removing that failover case. It appears to have a zero percent chance of succeeding anyway, so it shouldn't impact anything.

katerberg commented 2 weeks ago

Of note, this does not do the DOMPurify.sanitize that is needed on the href from popup.js as @jamespizzurro is going to do that separately.

jamespizzurro commented 2 weeks ago

Perfect, thank you! I'll have a crack at the rest of what Mozilla reported as part of #879 sometime this week, at which point we can release a new version of the browser extension and submit it to Mozilla for review.