search

jamespjh / eResearch-meeting-list

Apache License 2.0
5 stars 6 forks source link

updating eScience #46

Open danielskatz opened 4 years ago

vsoch commented 4 years ago

Previous should be a list I believe, since there will ultimately be more than one.

danielskatz commented 4 years ago

I had the - there first, but the check failed, so I removed it since it wasn't a list, and it seems the check still fails.

vsoch commented 4 years ago

I think it’s missing from the test, which is my fault! If it’s ok with you, I can PR to add it. It makes sense for previous to be a list right?

danielskatz commented 4 years ago

Yes, though if you want to make it a list, you probably should add another previous as well, e.g. https://www.escience2018.com Amsterdam, Netherlands 2018-10-29 2018-11-01

vsoch commented 4 years ago

It’s failing because the YAML loader can’t load the new file - I think the TBA needs to be removed for next if there is an entry.

vsoch commented 4 years ago

Definitely!

vsoch commented 4 years ago

@danielskatz just a note that the current eScience doesn't have any previous entries, so I didn't fold that into the PR]to keep it scoped to adding the test. The current is:

name: eScience
link: https://escience-conference.org
next: TBA
# 2020 in Osaka, Japan
danielskatz commented 4 years ago

See my PR on James’s repo

vsoch commented 4 years ago

Haha yes, I know, I was commenting that I didn't add it to the PR I just opened to add the test for a list.

vsoch commented 4 years ago

We are talking on said PR right now :)

danielskatz commented 4 years ago

It’s thanksgiving

vsoch commented 4 years ago

Happy Thanksgiving! I don't understand the connection, but I'm good with throwing some turkeys into the conversation :turkey: