Make error views smarter; add rate limit error view.

jamesplease / gistbook

[No longer hosted] A place to write about technical subjects on the web.

MIT License

88 stars 16 forks source link

Make error views smarter; add rate limit error view. #274

Closed jamesplease closed 9 years ago

jamesplease commented 9 years ago

Resolves #273

Todo:

[x] Rebase off patch
[x] When rate limited and not signed in, it should show a button recommending that you log in
[x] When rate limited and signed in, it should tell you how long you have to wait
[x] The styles between the error views should be shared

Some of those to-do's will be done in a subsequent update

jamesplease commented 9 years ago

Note to self:

this will be useful to me later

          newRoute.triggerMethod('error', {
            status: 403, getResponseHeader: function(header) {
              return header === 'X-RateLimit-Remaining' ? 0 : 1377013266;
            }
          });

Put this in the StateRouter to test these routes

jamesplease commented 9 years ago

The commit msg got messed up here, but I merged and fixed it over on patch. Will be released as v0.1.21!