search

jamesplease / materialish

React components that loosely follow Material Design
https://materialish.js.org
MIT License
17 stars 5 forks source link

0.17.0-beta: Navigation icon sizing #279

Closed jamesplease closed 6 years ago

jamesplease commented 6 years ago

With the change to support SVG sizes in Firefox ( #224 ), the Navigation SVG isn't sized properly.

image

In the CSS file, we have width/height set to 1.7em, but this is being overridden by the new inline styles.

@JPorry 's solution: inline styles of this format (ish):

{
  width: 'var(--varname, size || 1em)',
  ...
}

then, in the nav CSS, we set --varname.

jamesplease commented 6 years ago

Resolved in #281